Elliott Sales de Andrade: Author Summary

Builds triggered by Elliott Sales de Andrade

Builds triggered by an author are those builds which contains changes committed by the author.
14
1 (7%)
13 (93%)

Breakages and fixes

Broken means the build has failed but the previous build was successful.
Fixed means that the build was successful but the previous build has failed.
0 (0% of all builds triggered)
2 (14% of all builds triggered)
2
Build Completed Code commits Tests
PGN › PGRM › #166 18 hours ago
Replace g_snprintf+g_strdup by g_strdup_printf.
Remove unnecessary g_snprintf.

There's no need for a second copy of the gettext'd string.
Testless build
PGN › PPL › #203 2 days ago
Replace g_snprintf+g_strdup by g_strdup_printf.
Remove unnecessary g_snprintf.

There's no need for a second copy of the gettext'd string.
Testless build
PGN › QUL › #42 4 days ago
Remove unnecessary g_snprintf.

There's no need for a second copy of the gettext'd string.
Replace g_snprintf+g_strdup by g_strdup_printf.
Testless build
PGN › PGRM › #152 5 days ago
Fix use-after-free in MSN log reader.

I don't think `path` should be replaced since the next time in the loop
will produce something like `directory/old_filename/new_filename`, which
makes no sense even if there were no use-after-free.
Fix a leak in Pidgin.
Fix several g_build_filename leaks.
Fix another leak with possible use-after-free.
Fix jabber message thread handling.

Kind of guessing here based on struct contents though.
Correctly drop invalid SNACs.

A warning is printed and things are freed, but then it's not actually
ignored.
Fix some leaks in libpurple.
Fix leaky calls to purple_image_new_from_data.

It makes a copy itself; no need to do that before calling it.
Fix broken PurpleProxyInfo copying.
Fix some possible use-after-free.

Some of these are "false" positives since they are only comparing
pointers, but it's also technically undefined behaviour.
Testless build
PGN › QUL › #41 1 week ago
Fix another leak with possible use-after-free.
Fix jabber message thread handling.

Kind of guessing here based on struct contents though.
Fix use-after-free in MSN log reader.

I don't think `path` should be replaced since the next time in the loop
will produce something like `directory/old_filename/new_filename`, which
makes no sense even if there were no use-after-free.
Fix some possible use-after-free.

Some of these are "false" positives since they are only comparing
pointers, but it's also technically undefined behaviour.
Correctly drop invalid SNACs.

A warning is printed and things are freed, but then it's not actually
ignored.
Testless build
GPLUG › RWGRIM › #29 1 month ago
Fix various leaks in Python loader (hopefully).

These were mostly done by hand, based on the new/borrowed reference annotation
in the docs. Unfortunately, since we never deinitialize the interpreter, asan
still says most of these things leak.
flow: Created branch 'develop/asan'.
Fix leaks of regex results.
Fix leak of gplugin_plugin_get_filename results.

It's not a const char. The change from hash insert to hash replace is so that
the pointer of the new key stays valid for the rest of that block.
Fix leaks in tests.
Fix leak cleaning up file tree.

The root node *never* has ->data set to anything, so freeing the tree never
occurs.
Testless build
GPLUG › GPDEV › #19 1 month ago
Fix leaks in tests.
Fix leak cleaning up file tree.

The root node *never* has ->data set to anything, so freeing the tree never
occurs.
Fix leak of gplugin_plugin_get_filename results.

It's not a const char. The change from hash insert to hash replace is so that
the pointer of the new key stays valid for the rest of that block.
Fix various leaks in Python loader (hopefully).

These were mostly done by hand, based on the new/borrowed reference annotation
in the docs. Unfortunately, since we never deinitialize the interpreter, asan
still says most of these things leak.
flow: Created branch 'develop/asan'.
Fix leaks of regex results.
Testless build
TAL › TAL › #81 1 month ago
Fix some leaks in tests.
Fix buffer overflow in talkatu_action_group_get_activated_formats.

Also, removed the unnecessary g_strdup's. We already receive newly
allocated strings; there's no need to make *two* new copies.
Testless build
TAL › QULOGIC › #3 1 month ago
Fix some leaks in tests.
Fix buffer overflow in talkatu_action_group_get_activated_formats.

Also, removed the unnecessary g_strdup's. We already receive newly
allocated strings; there's no need to make *two* new copies.
Testless build
GPLUG › RWGRIM › #28 1 month ago
flow: Created branch 'feature/fix-gerror-crash'.
flow: Created branch 'feature/fix-valgrind'.
Fix warning from Python headers.
Fix double-setting of GError's.

When we call a function that may set the GError, setting it right after is just
a failsafe default value. We should not attempt to overwrite the existing
error.

Partial revert of 3e9310ee57d7.
Fix a use-after-free when plugins fail to load.
flow: Created branch 'feature/fix-perl-tcc'.
Fix use-after-free found in tests by valgrind.
flow: Created branch 'feature/fix-python-warning'.
Update Perl loader for new class hierarchy.
Update TCC loader for new class hierarchy.
Remove extra _plugin_ from GPluginPerlLoader.
Testless build
Build Completed Code commits Tests
Build Completed Code commits Tests
TAL › QULOGIC › #3 1 month ago
Fix some leaks in tests.
Fix buffer overflow in talkatu_action_group_get_activated_formats.

Also, removed the unnecessary g_strdup's. We already receive newly
allocated strings; there's no need to make *two* new copies.
Testless build
GPLUG › RWGRIM › #28 1 month ago
flow: Created branch 'feature/fix-gerror-crash'.
flow: Created branch 'feature/fix-valgrind'.
Fix warning from Python headers.
Fix double-setting of GError's.

When we call a function that may set the GError, setting it right after is just
a failsafe default value. We should not attempt to overwrite the existing
error.

Partial revert of 3e9310ee57d7.
Fix a use-after-free when plugins fail to load.
flow: Created branch 'feature/fix-perl-tcc'.
Fix use-after-free found in tests by valgrind.
flow: Created branch 'feature/fix-python-warning'.
Update Perl loader for new class hierarchy.
Update TCC loader for new class hierarchy.
Remove extra _plugin_ from GPluginPerlLoader.
Testless build